georgew5656 opened a new pull request, #16020:
URL: https://github.com/apache/druid/pull/16020
When a load rule specifies replicaCount=0, the affected segments will not be
loaded onto historicals but they are queryable via the multi-stage-query
engine. Currently these segments will be labeled as unavailable in
segment/unavailable/count which seems wrong to me since that metric indicates
that segments still need to be loaded.
The behavior is also different from segment/underReplicated/count since that
metric does not include replicaCount=0 segments as unavailable.
### Description
When checking whether to label a segment as unavailable for the purposes of
the segment/unavailable/count metric, check whether the required replicas is 0,
in which case the segment should not be marked as unavailable.
The segment/underReplicated/count already does this
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
This is a small one-line change to exclude non-historical segments from
being marked as unavailable. I tested this on my local machine with the logging
emitter and a test datasource.
#### Release note
- Clarify behavior of segment/unavailable/count and query from deep storage
feature
##### Key changed/added classes in this PR
* `DruidCoordinator`
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
