abhishekrb19 opened a new pull request, #16094: URL: https://github.com/apache/druid/pull/16094
[Issue 15951](https://github.com/apache/druid/issues/15951) is more of a gap in the test implementation `TestSegmentsMetadataManager`, where infinity intervals were not handled. In the actual implementation, there is special handling for this case in `appendConditionForIntervalsAndMatchMode`, so segments with eternity intervals will be cleaned up. I have removed the `@Ignore` test annotations and will close the [issue](https://github.com/apache/druid/issues/15951). Instead of extending `TestSegmentsMetadataManager` to match the actual implementation in `SqlSegmentsMetadataManager`, I've removed the unused segment functionality in `TestSegmentsMetadataManager` to make it a no-op. This is because it's too cumbersome to keep the test implementation in sync with the actual implementation, especially as we add more filtering capabilities to `SqlSegmentsMetadataManager`, so it'd be best to treat `SqlSegmentsMetadataManager` as the source of truth for most cases. The only drawback to this approach is that the functional tests are somewhat slower, now requiring the setup of Derby, etc. (e.g., 18s instead of 8s locally). <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
