kfaraz commented on code in PR #16094:
URL: https://github.com/apache/druid/pull/16094#discussion_r1519170052
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/KillUnusedSegmentsTest.java:
##########
@@ -644,6 +648,26 @@ public void testKillSecondHalfEternitySegment()
validateLastKillStateAndReset(DS1, secondHalfEternity);
}
+ @Test
+ public void testKillLargeIntervalSegments()
+ {
+ final Interval largeTimeRange1 =
Intervals.of("1990-01-01T00Z/19940-01-01T00Z");
Review Comment:
Are these intervals just meant to be large or half-eternity intervals?
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/KillUnusedSegmentsTest.java:
##########
@@ -898,4 +924,25 @@ void deleteLastKillTaskId(final String dataSource)
observedDatasourceToLastKillTaskId.remove(dataSource);
}
}
+
+ private void updateUsedStatusLastUpdated(DataSegment segment, DateTime
lastUpdatedTime)
Review Comment:
I think the only other test doing this is `SqlSegmentsMetadataManagerTest`.
So I guess we can leave this method as is for now.
What might be more useful though is adding an `update()` method in
`TestDerbyConnector` which does most of the boiler plate stuff. There are
similar updates being done in several other tests.
So essentially, move the method
`SqlSegmentsMetadataManagerTest.executeUpdate()` to `TestDerbyConnector`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
