abhishekrb19 commented on code in PR #16094:
URL: https://github.com/apache/druid/pull/16094#discussion_r1519178038


##########
server/src/test/java/org/apache/druid/server/coordinator/duty/KillUnusedSegmentsTest.java:
##########
@@ -644,6 +648,26 @@ public void testKillSecondHalfEternitySegment()
     validateLastKillStateAndReset(DS1, secondHalfEternity);
   }
 
+  @Test
+  public void testKillLargeIntervalSegments()
+  {
+    final Interval largeTimeRange1 = 
Intervals.of("1990-01-01T00Z/19940-01-01T00Z");

Review Comment:
   It is meant to be large for this specific test case. The unit test for half 
eternity is `testKillSecondHalfEternitySegment`. Keeping them as separate tests 
because the eternity and large intervals often tend to be snowflakes when it 
comes to querying.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to