LakshSingla commented on code in PR #16130:
URL: https://github.com/apache/druid/pull/16130#discussion_r1525991508
##########
processing/src/main/java/org/apache/druid/frame/write/FrameFieldWriterException.java:
##########
Review Comment:
I doubt that we need this class anywhere. Can't we use a generic
`RuntimeException` with the proper error message? Or better yet, use
DruidException, so that we can analyze the message.
##########
processing/src/main/java/org/apache/druid/frame/write/InvalidNullByteException.java:
##########
@@ -53,17 +50,16 @@ private InvalidNullByteException(
@Nullable final Integer position
)
{
- super(StringUtils.format(
+ super(column, StringUtils.format(
Review Comment:
Feels weird that we have this extra layer of indirection, to what will
essentially call the `RuntimeException`. If we don't extract the relevant
fields (`.getColumn()`) from the `FrameFieldWriterException` anywhere, or use
check for it's instanceof, then I suppose we can get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
