LakshSingla commented on code in PR #16130:
URL: https://github.com/apache/druid/pull/16130#discussion_r1549761358
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2983,6 +2984,20 @@ private MSQErrorReport
mapQueryColumnNameToOutputColumnName(
.build(),
task.getQuerySpec().getColumnMappings()
);
+ } else if (workerErrorReport.getFault() instanceof
FrameFieldWriterException) {
+ FrameFieldWriterException ffre = (FrameFieldWriterException)
workerErrorReport.getFault();
+ return MSQErrorReport.fromException(
+ workerErrorReport.getTaskId(),
+ workerErrorReport.getHost(),
+ workerErrorReport.getStageNumber(),
+ FrameFieldWriterException.builder()
+ .source(ffre.getSource())
+ .rowNumber(ffre.getRowNumber())
+ .column(ffre.getColumn())
+ .errorMsg(ffre.getErrorMsg())
+ .build(),
Review Comment:
Let's use the normal constructor since we are using all the parameters in a
single place. Invalid null byte exception has the builder because it populates
different information at different places up the call stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
