gargvishesh commented on PR #16130: URL: https://github.com/apache/druid/pull/16130#issuecomment-2029185932
> * Can you please add a test case where the exception gets generated? Tried multiple routes incl insert via external inline tables and insert via joins, but an error isn't generated. Therefore not adding the test case. > * Also, what does it mean for MSQ, should MSQ retry if it encounters such exceptions or not? It seems like retrying shouldn't help here, but per my understanding, MSQ will still treat errors like these as `UnknownFaults,` and will retry. We should update that logic in MSQ (check how we do it for `InvalidNullByte`) The conversion to `FrameFieldWriterFault` now puts it in the category of non-retryable errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
