abhishekrb19 commented on code in PR #16141:
URL: https://github.com/apache/druid/pull/16141#discussion_r1527940435
##########
server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java:
##########
@@ -990,37 +993,59 @@ static boolean
isSegmentLoaded(Iterable<ImmutableSegmentLoadInfo> servedSegments
return false;
}
+ /**
+ * Either {@code interval} or {@code segmentIds} array must be specified,
but not both.
+ * {@code versions} may be optionally specified only when {@code interval}
is provided.
+ */
@VisibleForTesting
- protected static class MarkDataSourceSegmentsPayload
+ static class MarkDataSourceSegmentsPayload
Review Comment:
Yes, thanks for the suggestion. Updated to `SegmentsToUpdateFilter`.
Regarding serializability, jackson should be able to serialize and
deserialize successfully as long as the members of the class are declared as
public. I also added a simple serde test to `DataSourcesResourceTest` even
though it's scoped in the same package, and ran a quick test manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
