abhishekrb19 commented on code in PR #16141:
URL: https://github.com/apache/druid/pull/16141#discussion_r1529184745
##########
server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java:
##########
@@ -589,6 +590,156 @@ public void testMarkAsUsedNonOvershadowedSegments()
throws Exception
);
}
+ @Test
+ public void
testMarkAsUsedNonOvershadowedSegmentsInEternityIntervalWithVersions() throws
Exception
Review Comment:
Not really, as `IndexerSQLMetadataStorageCoordinator` only exposes
`markSegmentsAsUnusedWithinInterval(String dataSource, Interval interval)`.
Tests already exist for the non-versions variation.
The methods with versions reside in `SegmentsMetadataManager`, and
`SqlSegmentsMetadataManagerTest` uses the concrete implementation, so we should
get code coverage from all of these new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
