abhishekrb19 commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1529658365
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalReplaceAction.java:
##########
@@ -141,22 +144,31 @@ private void tryUpgradeOverlappingPendingSegments(Task
task, TaskActionToolbox t
final SupervisorManager supervisorManager = toolbox.getSupervisorManager();
Review Comment:
General comment: this task action in particular is a bit more involved to
follow. I found the PR description quite useful to understand the high-level
flow. I would suggest including a version of that as javadocs in this class
itself.
Ditto for `SegmentTransactionalAppend`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
