AmatyaAvadhanula commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1529818253
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -387,7 +399,7 @@ public LockResult tryLock(final Task task, final
LockRequest request)
if (request instanceof LockRequestForNewSegment) {
final LockRequestForNewSegment lockRequestForNewSegment =
(LockRequestForNewSegment) request;
if (lockRequestForNewSegment.getGranularity() ==
LockGranularity.SEGMENT) {
- newSegmentId = allocateSegmentId(lockRequestForNewSegment,
request.getVersion());
+ newSegmentId = allocateSegmentId(lockRequestForNewSegment,
request.getVersion(), null);
Review Comment:
I suppose we could. My understanding of segment locking is limited which is
why I wanted to leave the behaviour intact if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
