AmatyaAvadhanula commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1556804390
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -324,7 +326,8 @@ SegmentPublishResult commitSegmentsAndMetadata(
*/
SegmentPublishResult commitAppendSegments(
Set<DataSegment> appendSegments,
- Map<DataSegment, ReplaceTaskLock> appendSegmentToReplaceLock
+ Map<DataSegment, ReplaceTaskLock> appendSegmentToReplaceLock,
+ String taskGroup
Review Comment:
Done
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -156,6 +156,13 @@ public Set<ResourceAction> getInputSourceResources()
return ImmutableSet.of();
}
+ @JsonIgnore
Review Comment:
Removed
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java:
##########
@@ -101,6 +101,12 @@ public interface Task
*/
String getGroupId();
+ /**
+ * The group used to associate a pending segment with a task
+ * @return task group for pending segment allocations
+ */
+ String getPendingSegmentGroup();
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
