YongGang commented on PR #16041: URL: https://github.com/apache/druid/pull/16041#issuecomment-2019337496
> Thanks for this feature @YongGang. I like the concept and can see some potential uses. I'm -1 on this current implementation. The biggest ~challenges~ changes I'd like to see are: > > 1. Updates to the interface so that it is focused on system generated tags instead of all tags > 2. It looks like in this current form, the tags are only applied on MSQ tasks. I think this should be hooked into all tasks given what the interface talks about. > 3. Integration tests are missing so it is possible this functionality could break > 4. Docs are missing indicating where the system tags could show up. Make some design changes: 1. The interface is refined to enrich tags in place 2. All tasks are hooked to the interface. 3. Now checking tags are in task report from integration test 4. Docs are updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
