arunramani commented on code in PR #16041:
URL: https://github.com/apache/druid/pull/16041#discussion_r1534727015
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -240,13 +241,14 @@ public TaskStatus runTask(final TaskToolbox toolbox)
throws Exception
injector.getInstance(Key.get(ServiceClientFactory.class,
EscalatedGlobal.class));
final OverlordClient overlordClient =
injector.getInstance(OverlordClient.class)
.withRetryPolicy(StandardRetryPolicy.unlimited());
+ final TaskIdentitiesProvider taskIdentitiesProvider =
injector.getInstance(TaskIdentitiesProvider.class);
Review Comment:
It could be implemented in a way that isn't so complicated. This is a
tagging provider and it makes sense to have multiple providers depending on
what the implemented finds useful. We do this with loggers and emitters and
such. Does this need to be any different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
