YongGang commented on code in PR #16041:
URL: https://github.com/apache/druid/pull/16041#discussion_r1534887967
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -691,6 +700,9 @@ private QueryDefinition initializeQueryDefAndState(final
Closer closer)
MSQControllerTask.isReplaceInputDataSourceTask(task)
);
+ // propagate the controller's tags to the worker task
+ taskContextOverridesBuilder.put(DruidMetrics.TAGS,
taskIdentitiesProvider.getTaskMetricTags(task));
+
Review Comment:
We need `taskIdentitiesProvider` to help identify the purpose of the task.
For MSQ tasks, the purpose of what the task do is mainly inferred from
`MSQControllerTask.spec`, `MSQWorkerTask` doesn't have this info, you can see
`MSQWorkerTask` class itself it's very simple. Thus these info need to be
passed in from the parent Controller task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
