adarshsanjeev commented on code in PR #15953:
URL: https://github.com/apache/druid/pull/15953#discussion_r1538634671
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessorFactory.java:
##########
@@ -107,7 +112,14 @@ public ProcessorsAndChannels<Object, Long> makeProcessors(
);
if (inputSliceReader.numReadableInputs(slice) == 0) {
- return new ProcessorsAndChannels<>(ProcessorManagers.none(),
OutputChannels.none());
+ return new ProcessorsAndChannels<>(
+ ProcessorManagers.of(Sequences.<ExportResultsFrameProcessor>empty())
+ .withAccumulation(new ArrayList<String>(), (acc,
file) -> {
+ ((ArrayList<String>) acc).add((String) file);
+ return acc;
+ }),
Review Comment:
We need the withAccumulation call so that the types match, but I have
changed it to be a noop instead, more in line with other places.
https://github.com/apache/druid/blob/9c7d7fc77748a6b8534f1ec3c36e226c63f8cfe7/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/processor/SegmentGeneratorFrameProcessorFactory.java#L132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
