gianm commented on code in PR #15953:
URL: https://github.com/apache/druid/pull/15953#discussion_r1566520352
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1790,6 +1794,25 @@ private void publishSegmentsIfNeeded(
}
log.info("Query [%s] publishing %d segments.", queryDef.getQueryId(),
segments.size());
publishAllSegments(segments);
+ } else if (MSQControllerTask.isExport(task.getQuerySpec())) {
+ // Write manifest file.
+ ExportMSQDestination destination = (ExportMSQDestination)
task.getQuerySpec().getDestination();
+ ExportMetadataManager exportMetadataManager = new
ExportMetadataManager(destination.getExportStorageProvider());
+
+ final StageId finalStageId =
queryKernel.getStageId(queryDef.getFinalStageDefinition().getStageNumber());
+ //noinspection unchecked
+
+
+ Object resultObjectForStage =
queryKernel.getResultObjectForStage(finalStageId);
+ if (!(resultObjectForStage instanceof List)) {
+ // This might occur if all workers are running on an older version. We
are not able to write a manifest file in this case.
+ log.warn("Was unable to create manifest file due to ");
Review Comment:
@adarshsanjeev looks like a log message is incomplete here- what should this
say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
