suneet-s commented on code in PR #16247:
URL: https://github.com/apache/druid/pull/16247#discussion_r1558082235
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java:
##########
@@ -47,9 +45,15 @@ public abstract class DruidCoordinatorConfig
@Default("false")
public abstract boolean isKillUnusedSegmentsEnabled();
+ /**
+ * @return The period at which the coordinator cleans up unused segments. If
the config isn't explicitly set,
+ * it defaults to the coordinator's indexing period.
+ */
@Config("druid.coordinator.kill.period")
- @Default("P1D")
- public abstract Duration getCoordinatorKillPeriod();
+ public Duration getCoordinatorKillPeriod()
+ {
+ return getCoordinatorIndexingPeriod();
Review Comment:
```suggestion
return getCoordinatorKillIgnoreDurationToRetain() ?
getCoordinatorIndexingPeriod() : Duration.standardDays(1);;
```
Since the default for `ignoreDurationToRetain` is still false by default -
should the default kill period remain 1 day unless `ignoreDurationToRetain` is
true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
