abhishekrb19 opened a new pull request, #16247: URL: https://github.com/apache/druid/pull/16247
#### Problem: When `druid.coordinator.kill.period` is set to something other than the coordinator's indexing period, it can cause confusion regarding when the duty will run. Please https://github.com/apache/druid/issues/15911 for an example. Also, the default `P1D` may be overly conservative for most users. #### Fix: Fixes https://github.com/apache/druid/issues/15911. With sufficient guard rails available in the kill duty, the duty can just run regularly at the same time as the coordinator's indexing period. - By default, when `druid.coordinator.kill.period` is not set explicitly, it will take the value of `druid.coordinator.period.indexingPeriod` (whether it's the default or an overridden value) - As before, an operator can choose to override `druid.coordinator.kill.period` and this will take precedence over the default behavior noted above. We have been successfully running the auto-kill duty in production with `druid.coordinator.kill.period` set to `druid.coordinator.period.indexingPeriod`, even at `PT15M`. Note that we could deprecate `druid.coordinator.kill.period`, but in the ethos of providing flexibility to operators, this patch doesn't do so. #### Other related changes - The eternity interval comment is inaccurate - Break up the tests in `DruidCoordinatorConfigTest` #### Release note The default value for `druid.coordinator.kill.period` (if unspecified) has changed from `P1D` to the value of `druid.coordinator.period.indexingPeriod`. Operators can choose to override `druid.coordinator.kill.period` and that will take precedence over the default behavior. This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
