abhishekrb19 commented on code in PR #16247:
URL: https://github.com/apache/druid/pull/16247#discussion_r1558772693
##########
server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorConfigTest.java:
##########
@@ -27,59 +27,63 @@
import java.util.Properties;
-/**
- */
public class DruidCoordinatorConfigTest
{
@Test
- public void testDeserialization()
+ public void testCoordinatorConfigWithDefaults()
{
- ConfigurationObjectFactory factory = Config.createFactory(new
Properties());
-
- //with defaults
- DruidCoordinatorConfig config =
factory.build(DruidCoordinatorConfig.class);
+ final ConfigurationObjectFactory factory = Config.createFactory(new
Properties());
+ final DruidCoordinatorConfig config =
factory.build(DruidCoordinatorConfig.class);
Assert.assertEquals(new Duration("PT300s"),
config.getCoordinatorStartDelay());
Assert.assertEquals(new Duration("PT60s"), config.getCoordinatorPeriod());
Assert.assertEquals(new Duration("PT1800s"),
config.getCoordinatorIndexingPeriod());
- Assert.assertEquals(86400000,
config.getCoordinatorKillPeriod().getMillis());
- Assert.assertEquals(7776000000L,
config.getCoordinatorKillDurationToRetain().getMillis());
+ Assert.assertEquals(new Duration("PT1800s"),
config.getCoordinatorKillPeriod());
+ Assert.assertEquals(new Duration("PT7776000s"),
config.getCoordinatorKillDurationToRetain());
Review Comment:
Only the default for `druid.coordinator.kill.period`, which is set to the
coordinator's indexing period and the assert is in line 41. This line 42 is
asserting the `druid.coordinator.kill.durationToRetain` property whose default
`P1D` hasn't changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
