gianm commented on code in PR #16168:
URL: https://github.com/apache/druid/pull/16168#discussion_r1558117581
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/kernel/controller/MockQueryDefinitionBuilder.java:
##########
@@ -113,27 +126,60 @@
);
definedStages.add(stageNumber);
- ShuffleSpec shuffleSpec;
+ ShuffleSpec shuffleSpec = null;
- if (shuffling) {
- shuffleSpec = new GlobalSortMaxCountShuffleSpec(
- new ClusterBy(
- ImmutableList.of(
- new KeyColumn(SHUFFLE_KEY_COLUMN, KeyOrder.ASCENDING)
+ if (shuffleKind != null) {
+ switch (shuffleKind) {
+ case GLOBAL_SORT:
+ shuffleSpec = new GlobalSortMaxCountShuffleSpec(
+ new ClusterBy(
+ ImmutableList.of(
+ new KeyColumn(SHUFFLE_KEY_COLUMN, KeyOrder.ASCENDING)
+ ),
+ 0
),
- 0
- ),
- MAX_NUM_PARTITIONS,
- false
- );
- } else {
- shuffleSpec = null;
+ MAX_NUM_PARTITIONS,
+ false
+ );
+ break;
+
+ case HASH_LOCAL_SORT:
+ case HASH:
+ shuffleSpec = new HashShuffleSpec(
+ new ClusterBy(
+ ImmutableList.of(
+ new KeyColumn(
+ SHUFFLE_KEY_COLUMN,
+ shuffleKind == ShuffleKind.HASH ? KeyOrder.NONE :
KeyOrder.ASCENDING
+ )
+ ),
+ 0
+ ),
+ MAX_NUM_PARTITIONS
+ );
+ break;
+
+ case MIX:
+ shuffleSpec = MixShuffleSpec.instance();
+ break;
+ }
+
+ if (shuffleKind != shuffleSpec.kind()) {
Review Comment:
fixed.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerContext.java:
##########
@@ -53,32 +71,33 @@
DruidNode selfNode();
/**
- * Provide access to the Coordinator service.
+ * Provides an {@link InputSpecSlicer} that slices {@link TableInputSpec}
into {@link SegmentsInputSlice}.
*/
- CoordinatorClient coordinatorClient();
+ InputSpecSlicer newTableInputSpecSlicer(WorkerManager workerManager);
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
