cryptoe commented on code in PR #16168:
URL: https://github.com/apache/druid/pull/16168#discussion_r1579245838
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerContext.java:
##########
@@ -21,24 +21,44 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.inject.Injector;
-import org.apache.druid.client.coordinator.CoordinatorClient;
-import org.apache.druid.indexer.report.TaskReport;
import org.apache.druid.indexing.common.actions.TaskActionClient;
import org.apache.druid.java.util.common.io.Closer;
import org.apache.druid.java.util.emitter.service.ServiceEmitter;
+import org.apache.druid.msq.indexing.MSQSpec;
+import org.apache.druid.msq.input.InputSpecSlicer;
+import org.apache.druid.msq.input.table.SegmentsInputSlice;
+import org.apache.druid.msq.input.table.TableInputSpec;
+import org.apache.druid.msq.kernel.QueryDefinition;
+import org.apache.druid.msq.kernel.controller.ControllerQueryKernelConfig;
import org.apache.druid.server.DruidNode;
/**
- * Context used by multi-stage query controllers.
- *
- * Useful because it allows test fixtures to provide their own implementations.
+ * Context used by multi-stage query controllers. Useful because it allows
test fixtures to provide their own
+ * implementations.
*/
public interface ControllerContext
{
- ServiceEmitter emitter();
+ /**
+ * Configuration for {@link
org.apache.druid.msq.kernel.controller.ControllerQueryKernel}.
+ */
+ ControllerQueryKernelConfig queryKernelConfig(MSQSpec querySpec,
QueryDefinition queryDef);
+ /**
+ * Callback from the controller implementation to "register" the controller.
Used in the indexing task implementation
+ * to set up the task chat web service.
+ */
+ void registerController(Controller controller, Closer closer);
Review Comment:
The controller context should be owned by a controller. This method feels
weird to me . If we need to register a closer, then we can add a addCloser()
method to this interface no ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
