gianm commented on PR #16153:
URL: https://github.com/apache/druid/pull/16153#issuecomment-2049007865
This test has an issue on the latest patch:
```
assertMatch("%1 _ 5%6", "1 2 3 1 4 5 6", DruidPredicateMatch.TRUE);
```
The matcher strips off the `6` to get `1 2 3 1 4 5 `, then eagerly matches
the first `1 ` using the `%1 `, then can't match `_ 5` on the start of `2 3 1 4
5 ` and returns `FALSE`.
I'm not sure how to fix it, so am definitely interested in your thoughts.
I'm happy to take a look at any fixes you propose. Another possible option is
to include Joni or re2j, and use it here as well as optionally use it for the
`REGEXP_*` functions. Or adapt the DFA approach that Trino is using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
