twilliamson commented on PR #16153: URL: https://github.com/apache/druid/pull/16153#issuecomment-2050082812
You're right: I'm making the same mistake as with the suffix — and now worrying I left the same bug in the Facebook stream processing system… 😛 Sequences of literal characters and `_` without any `%` between them have to either all match or all fail. That's certainly doable to code up, and still has better theortical bounds than `java.util.regex`, but whether it's faster than the `joni`/`re2` option (or better enough to warrant the additional complexity) is a good question. I'll try out the different options… Thanks so much for taking a look at this MR — and extra, extra thanks for spotting the flaws! 😄 I was grateful to finally feel like I could contribute to some of the awesomeness of Druid, and it would have been horrifying to end up introducing bugs into `LIKE`. 🙀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
