kfaraz commented on code in PR #16144: URL: https://github.com/apache/druid/pull/16144#discussion_r1563966881
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java: ########## @@ -119,7 +119,8 @@ import java.util.concurrent.TimeoutException; @Deprecated -public class AppenderatorDriverRealtimeIndexTask extends AbstractTask implements ChatHandler +public class AppenderatorDriverRealtimeIndexTask extends AbstractTask Review Comment: Yeah, I guess if we are doing allocation, we might as well populate the fields correctly even if they might not be needed for concurrent append/replace. ########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ########## @@ -137,7 +137,7 @@ import java.util.function.Function; import java.util.stream.Collectors; -public class IndexTask extends AbstractBatchIndexTask implements ChatHandler +public class IndexTask extends AbstractBatchIndexTask implements ChatHandler, PendingSegmentAllocatingTask Review Comment: 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
