kfaraz commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1563967710
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalAppendAction.java:
##########
@@ -132,19 +133,20 @@ public SegmentPublishResult perform(Task task,
TaskActionToolbox toolbox)
= TaskLocks.findReplaceLocksCoveringSegments(datasource,
toolbox.getTaskLockbox(), segments);
final CriticalAction.Action<SegmentPublishResult> publishAction;
+ final String pendingSegmentGroupId = ((PendingSegmentAllocatingTask)
task).getPendingSegmentGroupId();
Review Comment:
Yes, that is correct. But nothing is stopping any other type of task from
submitting this action to the overlord. Which is why we need a validation that
the action is being invoked by the correct type of task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
