AmatyaAvadhanula commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1566603996
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalAppendAction.java:
##########
@@ -132,19 +133,20 @@ public SegmentPublishResult perform(Task task,
TaskActionToolbox toolbox)
= TaskLocks.findReplaceLocksCoveringSegments(datasource,
toolbox.getTaskLockbox(), segments);
final CriticalAction.Action<SegmentPublishResult> publishAction;
+ final String pendingSegmentGroupId = ((PendingSegmentAllocatingTask)
task).getPendingSegmentGroupId();
Review Comment:
Added validation
##########
server/src/main/java/org/apache/druid/metadata/PendingSegmentRecord.java:
##########
@@ -74,16 +74,18 @@ public String getSequencePrevId()
return sequencePrevId;
}
+ @Nullable
@JsonProperty
- public String getParentId()
+ public String getUpgradedFromSegmentId()
{
- return parentId;
+ return upgradedFromSegmentId;
}
+ @Nullable
@JsonProperty
- public String getTaskGroup()
+ public String getTaskAllocatorId()
Review Comment:
Added
##########
server/src/main/java/org/apache/druid/indexing/overlord/SegmentCreateRequest.java:
##########
@@ -82,13 +82,13 @@ public PartialShardSpec getPartialShardSpec()
return partialShardSpec;
}
- public String getParentId()
+ public String getUpgradedFromSegmentId()
{
- return parentId;
+ return upgradedFromSegmentId;
}
- public String getTaskGroup()
+ public String getTaskAllocatorId()
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
