cryptoe commented on code in PR #15817:
URL: https://github.com/apache/druid/pull/15817#discussion_r1565177474
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/processor/SegmentGeneratorFrameProcessorFactory.java:
##########
@@ -57,41 +58,43 @@
import org.apache.druid.segment.incremental.RowIngestionMeters;
import org.apache.druid.segment.indexing.DataSchema;
import org.apache.druid.segment.indexing.TuningConfig;
+import org.apache.druid.segment.metadata.CentralizedDatasourceSchemaConfig;
import org.apache.druid.segment.realtime.appenderator.Appenderator;
import org.apache.druid.segment.realtime.appenderator.AppenderatorConfig;
import org.apache.druid.segment.realtime.appenderator.Appenderators;
import org.apache.druid.segment.realtime.appenderator.SegmentIdWithShardSpec;
import org.apache.druid.segment.writeout.SegmentWriteOutMediumFactory;
import org.apache.druid.sql.calcite.planner.ColumnMappings;
-import org.apache.druid.timeline.DataSegment;
import org.joda.time.Period;
import javax.annotation.Nullable;
import java.io.File;
-import java.util.HashSet;
import java.util.List;
import java.util.Objects;
-import java.util.Set;
import java.util.function.Consumer;
@JsonTypeName("segmentGenerator")
public class SegmentGeneratorFrameProcessorFactory
- implements FrameProcessorFactory<DataSegment, Set<DataSegment>,
List<SegmentIdWithShardSpec>>
+ implements FrameProcessorFactory<DataSegmentWithSchemas,
DataSegmentWithSchemas, List<SegmentIdWithShardSpec>>
Review Comment:
This effectifvely breaks backword compatibility of MSQ during rolling
upgrade.
https://github.com/apache/druid/blob/c72e69a8c8aff192a22f5f198e61722380832380/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java#L908-L912
I suggest reverting the MSQ changes till we have a clear path forward
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/processor/SegmentGeneratorFrameProcessorFactory.java:
##########
@@ -57,41 +58,43 @@
import org.apache.druid.segment.incremental.RowIngestionMeters;
import org.apache.druid.segment.indexing.DataSchema;
import org.apache.druid.segment.indexing.TuningConfig;
+import org.apache.druid.segment.metadata.CentralizedDatasourceSchemaConfig;
import org.apache.druid.segment.realtime.appenderator.Appenderator;
import org.apache.druid.segment.realtime.appenderator.AppenderatorConfig;
import org.apache.druid.segment.realtime.appenderator.Appenderators;
import org.apache.druid.segment.realtime.appenderator.SegmentIdWithShardSpec;
import org.apache.druid.segment.writeout.SegmentWriteOutMediumFactory;
import org.apache.druid.sql.calcite.planner.ColumnMappings;
-import org.apache.druid.timeline.DataSegment;
import org.joda.time.Period;
import javax.annotation.Nullable;
import java.io.File;
-import java.util.HashSet;
import java.util.List;
import java.util.Objects;
-import java.util.Set;
import java.util.function.Consumer;
@JsonTypeName("segmentGenerator")
public class SegmentGeneratorFrameProcessorFactory
- implements FrameProcessorFactory<DataSegment, Set<DataSegment>,
List<SegmentIdWithShardSpec>>
+ implements FrameProcessorFactory<DataSegmentWithSchemas,
DataSegmentWithSchemas, List<SegmentIdWithShardSpec>>
Review Comment:
To have backward compatibility, you would need to have a pojo which can be
created from a the json deserialized version of `set<dataSegments>` since that
is sent over the wire.
Maybe something like
Set<DataSegmentPlus> where datasegmentplus extends datasegment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
