findingrish commented on code in PR #15817:
URL: https://github.com/apache/druid/pull/15817#discussion_r1567007662
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1947,13 +1992,46 @@ public int deletePendingSegments(String dataSource)
private Set<DataSegment> announceHistoricalSegmentBatch(
final Handle handle,
final Set<DataSegment> segments,
- final Set<DataSegment> usedSegments
+ final Set<DataSegment> usedSegments,
+ @Nullable final MinimalSegmentSchemas minimalSegmentSchemas
) throws IOException
{
final Set<DataSegment> toInsertSegments = new HashSet<>();
+ Map<String, Long> fingerprintSchemaIdMap = null;
+ boolean schemaPresent = false;
try {
+ if (!publishSchema()) {
+ log.info("Task schema publish is disabled.");
+ }
+ if (publishSchema()
+ && minimalSegmentSchemas != null
+ && minimalSegmentSchemas.isNonEmpty()
+ ) {
+ String dataSource =
segments.stream().iterator().next().getDataSource();
+ schemaPresent = true;
+ log.info("Persisting segment schema: [%s].", minimalSegmentSchemas);
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
