IgorBerman commented on code in PR #16266:
URL: https://github.com/apache/druid/pull/16266#discussion_r1572445610
##########
server/src/main/java/org/apache/druid/query/lookup/LookupSerdeModule.java:
##########
@@ -58,6 +59,7 @@ public List<? extends Module> getJacksonModules()
public void configure(Binder binder)
{
JsonConfigProvider.bind(binder, LookupModule.PROPERTY_BASE,
LookupConfig.class);
+ binder.bind(LookupNodeService.class).toInstance(new
LookupNodeService(LookupListeningAnnouncerConfig.DEFAULT_TIER));
Review Comment:
added
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/ForkingTaskRunnerTest.java:
##########
@@ -537,6 +539,115 @@ ProcessHolder runTaskProcess(List<String> command, File
logFile, TaskLocation ta
Assert.assertTrue(forkingTaskRunner.restore().isEmpty());
}
+ @Test
+ public void testTaskRun_doesnt_pass_loadLookups_Argument() throws Exception
Review Comment:
renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
