kfaraz commented on code in PR #16266:
URL: https://github.com/apache/druid/pull/16266#discussion_r1572735589
##########
server/src/main/java/org/apache/druid/query/lookup/LookupSerdeModule.java:
##########
@@ -58,6 +59,9 @@ public List<? extends Module> getJacksonModules()
public void configure(Binder binder)
{
JsonConfigProvider.bind(binder, LookupModule.PROPERTY_BASE,
LookupConfig.class);
+ //Even though LookupSerdeModule will be used for processes that are not
loading lookups, we need to bind LookupNodeService,
+ //so that TaskToolboxFactory and TaskToolbox will get their dependency.
Binding it won't load lookups.
Review Comment:
Hmm, I suppose we could have just made this dependency `@Nullable` in
`TaskToolboxFactory`.
The only usage is to build a `DruidDiscoveryNode` where the
`LookupNodeService` object is used to populate the services map.
From the point of service discovery, I think it would be more appropriate to
just not add the lookup node service to the map rather than declaring a dummy
node service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
