IgorBerman commented on code in PR #16266:
URL: https://github.com/apache/druid/pull/16266#discussion_r1573314626
##########
server/src/main/java/org/apache/druid/query/lookup/LookupSerdeModule.java:
##########
@@ -58,6 +59,9 @@ public List<? extends Module> getJacksonModules()
public void configure(Binder binder)
{
JsonConfigProvider.bind(binder, LookupModule.PROPERTY_BASE,
LookupConfig.class);
+ //Even though LookupSerdeModule will be used for processes that are not
loading lookups, we need to bind LookupNodeService,
+ //so that TaskToolboxFactory and TaskToolbox will get their dependency.
Binding it won't load lookups.
Review Comment:
tried this and got following error for compaction task
````
Exception in thread "main" java.lang.RuntimeException:
java.lang.RuntimeException: com.google.inject.CreationException: Unable to
create injector, see the following errors:
1) Could not find a suitable constructor in
org.apache.druid.discovery.LookupNodeService. Classes must have either one (and
only one) constructor annotated with @Inject or a zero-argument constructor
that is not private.
at
org.apache.druid.discovery.LookupNodeService.class(LookupNodeService.java:38)
while locating org.apache.druid.discovery.LookupNodeService
for the 26th parameter of
org.apache.druid.indexing.common.TaskToolboxFactory.<init>(TaskToolboxFactory.java:165)
at org.apache.druid.cli.CliPeon.bindTaskConfigAndClients(CliPeon.java:506)
(via modules: com.google.inject.util.Modules$OverrideModule ->
com.google.inject.util.Modules$OverrideModule -> org.apache.druid.cli.CliPeon$1)
1 error
at org.apache.druid.cli.CliPeon.run(CliPeon.java:421)
at org.apache.druid.cli.Main.main(Main.java:112)
Caused by: java.lang.RuntimeException: com.google.inject.CreationException:
Unable to create injector, see the following errors:
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
