IgorBerman commented on PR #16323: URL: https://github.com/apache/druid/pull/16323#issuecomment-2072178748
if testing framework makes sure that each test runs one after another and not in parallel, other option would be to reset static variables in some visible for test method. Additional option would be to use some interface that a) decouples from ForkingTaskRunnerTest & WorkerTaskCountStatsProvider and b) "collects" reports from ForkingTaskRunnerTest. for tests it will 1 implementation, race free. for production it can wrap those static variables and WorkerTaskCountStatsProvider will take those reports from this interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
