kfaraz commented on PR #16323: URL: https://github.com/apache/druid/pull/16323#issuecomment-2073912308
> don't you think there should be failedTaskCount .incrementAndGet(); near LOGGER.info(t, "Exception caught during execution"); at wrapping try-catch? Yes, I wanted to do this but I decided to do it later as I need to look at all the exceptions and if it would be better to not throw an exception at all and simply return a `TaskStatus.failure()` in those cases. But I need to test it properly before making those changes. The changes in this PR are more straightforward and just meant to get the build right without altering any behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
