kfaraz commented on code in PR #16323:
URL: https://github.com/apache/druid/pull/16323#discussion_r1577435884
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/ForkingTaskRunnerTest.java:
##########
@@ -494,7 +493,7 @@ int waitForTaskProcessToComplete(Task task, ProcessHolder
processHolder, File lo
+ task.getId()
+ " must be an array of
strings.")
);
- Assert.assertEquals(1L, (long)
forkingTaskRunner.getWorkerFailedTaskCount());
+ Assert.assertEquals(0L, (long)
forkingTaskRunner.getWorkerFailedTaskCount());
Review Comment:
Yes, ideally the failed count should be 1, but it is currently not being
tracked.
We can fix up the code later as mentioned here:
https://github.com/apache/druid/pull/16323#issuecomment-2073912308.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
