AmatyaAvadhanula opened a new pull request, #16324:
URL: https://github.com/apache/druid/pull/16324
A Task or Supervisor must not have its segment granularity strictly finer
than its query granularity.
### Problem
Today, an appending task fails during segment allocation in cases of such
misconfiguration. When such a supervisor is submitted, the tasks are spawned
and failed repetitively and this leads to a waste of resources.
### Changes
This PR adds a check to ensure that the UniformGranularitySpec has a segment
granularity equal to or coarser than its query granularity.
### Testing
Verified that tasks cannot be submitted with a segment granularity finer
than the query granularity.
Similarly, verified that a new supervisor with such a misconfigured
granularity spec cannot be submitted. Also, ensured that an existing supervisor
is unaffected after attempting to submit such a supervisor with the same id.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
