AmatyaAvadhanula commented on code in PR #16324:
URL: https://github.com/apache/druid/pull/16324#discussion_r1576828808
##########
server/src/test/java/org/apache/druid/segment/indexing/granularity/UniformGranularityTest.java:
##########
@@ -358,6 +359,18 @@ public void
testUniformGranularitySpecWithLargeNumberOfIntervalsDoesNotBlowUp()
Assert.assertEquals(3600 * 24 * 365 * 10 + 3 * 24 * 3600, count);
}
+ @Test(expected = DruidException.class)
+ public void testCheckGranularityValidity()
+ {
+ new UniformGranularitySpec(
+ Granularities.SECOND,
Review Comment:
Added a test where I Assert.fail() in the catch block. Could you please let
me know if that works?
##########
server/src/test/java/org/apache/druid/segment/indexing/granularity/UniformGranularityTest.java:
##########
@@ -358,6 +359,18 @@ public void
testUniformGranularitySpecWithLargeNumberOfIntervalsDoesNotBlowUp()
Assert.assertEquals(3600 * 24 * 365 * 10 + 3 * 24 * 3600, count);
}
+ @Test(expected = DruidException.class)
+ public void testCheckGranularityValidity()
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
