abhishekrb19 commented on code in PR #16324:
URL: https://github.com/apache/druid/pull/16324#discussion_r1577259760
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java:
##########
@@ -1492,7 +1492,7 @@ public void
testQueryGranularityAndNullSegmentGranularity() throws IOException
null,
null,
null,
- new ClientCompactionTaskGranularitySpec(null, new
PeriodGranularity(Period.months(3), null, null), null),
+ new ClientCompactionTaskGranularitySpec(null, Granularities.HOUR,
null),
Review Comment:
Related to
[this](https://github.com/apache/druid/pull/16324/files#r1577256445) comment,
please keep the test inputs as they are and only update the expected result. In
this case, the test should throw an exception due to the added validation.
Separately, we can add a new test with valid input as you have done here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
