kgyrtkirk commented on code in PR #16312:
URL: https://github.com/apache/druid/pull/16312#discussion_r1589115815
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/Expressions.java:
##########
@@ -306,61 +308,85 @@ private static DruidExpression rexCallToDruidExpression(
}
}
+ /**
+ * Create a {@link DruidLiteral} from a literal {@link RexNode}. Necessary
because Calcite represents literals using
+ * different Java classes than Druid does.
+ *
+ * @param plannerContext planner context
+ * @param rexNode Calcite literal
+ *
+ * @return converted literal, or null if the literal cannot be converted
+ */
@Nullable
- static DruidExpression literalToDruidExpression(
+ public static DruidLiteral calciteLiteralToDruidLiteral(
final PlannerContext plannerContext,
final RexNode rexNode
)
{
- final SqlTypeName sqlTypeName = rexNode.getType().getSqlTypeName();
+ if (rexNode.isA(SqlKind.CAST)) {
+ if (SqlTypeFamily.DATE.contains(rexNode.getType())) {
+ // Cast to DATE suggests some timestamp flooring. We don't deal with
that here, so return null.
+ return null;
+ }
+
+ final DruidLiteral innerLiteral =
+ calciteLiteralToDruidLiteral(plannerContext, ((RexCall)
rexNode).getOperands().get(0));
+ if (innerLiteral == null) {
+ return null;
+ }
+
+ final ColumnType castToColumnType =
Calcites.getColumnTypeForRelDataType(rexNode.getType());
+ if (castToColumnType == null) {
+ return null;
+ }
+
+ final ExpressionType castToExprType =
ExpressionType.fromColumnType(castToColumnType);
+ if (castToExprType == null) {
+ return null;
+ }
+
+ return innerLiteral.castTo(castToExprType);
+ }
// Translate literal.
- final ColumnType columnType =
Calcites.getColumnTypeForRelDataType(rexNode.getType());
+ final SqlTypeName sqlTypeName = rexNode.getType().getSqlTypeName();
+ final DruidLiteral retVal;
+
if (RexLiteral.isNullLiteral(rexNode)) {
- return DruidExpression.ofLiteral(columnType,
DruidExpression.nullLiteral());
+ final ColumnType columnType =
Calcites.getColumnTypeForRelDataType(rexNode.getType());
+ final ExpressionType expressionType = columnType == null ? null :
ExpressionType.fromColumnTypeStrict(columnType);
+ retVal = new DruidLiteral(expressionType, null);
} else if (SqlTypeName.INT_TYPES.contains(sqlTypeName)) {
final Number number = (Number) RexLiteral.value(rexNode);
- return DruidExpression.ofLiteral(
- columnType,
- number == null ? DruidExpression.nullLiteral() :
DruidExpression.longLiteral(number.longValue())
- );
+ retVal = new DruidLiteral(ExpressionType.LONG, number == null ? null :
number.longValue());
Review Comment:
note: I don't think `number` could be null in these cases; it should have
already taken the `RexLiteral#isNullLiteral`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
