gianm commented on PR #16312: URL: https://github.com/apache/druid/pull/16312#issuecomment-2079680355
> Just pushed an additional change to the test cases that reflects that certain expressions will now be generated with `null` instead of `''` in default-value mode. This is due to the adjustment to break up `Expressions.literalToDruidExpression`. I believe this won't change runtime behavior, because in default-value mode both `null` and `''` are parsed into the same `StringExpr(null)` anyway. FYI, I undid this change, in favor of introducing an `ExprEvalWrapper` that allows us to retain the difference between `null` and `''`. I believe that the new approach, with retained differences, will make switching between null handling modes more smooth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
