gianm commented on code in PR #16312: URL: https://github.com/apache/druid/pull/16312#discussion_r1581245016
########## sql/src/main/java/org/apache/druid/sql/calcite/expression/ExprEvalWrapper.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.expression; + +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.math.expr.ExprEval; + +/** + * Wraps an {@link ExprEval} and provides an additional {@link #trueValue()} method to allow callers in + * {@link NullHandling#replaceWithDefault()} mode to determine whether the {@link ExprEval} represents a true + * null or an empty string. + */ +public class ExprEvalWrapper +{ + private final ExprEval<?> eval; + private final boolean isEmptyString; + + public ExprEvalWrapper(ExprEval<?> eval, boolean isEmptyString) + { + this.eval = eval; + this.isEmptyString = isEmptyString; + } + + public ExprEval<?> exprEval() + { + return eval; + } + + /** + * Like calling {@link ExprEval#value()} on {@link #exprEval()}, but in {@link NullHandling#replaceWithDefault()} + * mode, returns empty string rather than null if eval should truly be an empty string. + */ + public Object trueValue() Review Comment: I thought about it a bit and renamed this to `actualValue`. It seems clearest to me. ########## sql/src/main/java/org/apache/druid/sql/calcite/expression/ExprEvalWrapper.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.expression; + +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.math.expr.ExprEval; + +/** + * Wraps an {@link ExprEval} and provides an additional {@link #trueValue()} method to allow callers in + * {@link NullHandling#replaceWithDefault()} mode to determine whether the {@link ExprEval} represents a true + * null or an empty string. + */ +public class ExprEvalWrapper +{ + private final ExprEval<?> eval; + private final boolean isEmptyString; + + public ExprEvalWrapper(ExprEval<?> eval, boolean isEmptyString) + { + this.eval = eval; + this.isEmptyString = isEmptyString; + } + + public ExprEval<?> exprEval() + { + return eval; + } + + /** + * Like calling {@link ExprEval#value()} on {@link #exprEval()}, but in {@link NullHandling#replaceWithDefault()} + * mode, returns empty string rather than null if eval should truly be an empty string. + */ + public Object trueValue() Review Comment: I thought about it a bit and renamed this to `actualValue()`. It seems clearest to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
