johnImply commented on code in PR #16310:
URL: https://github.com/apache/druid/pull/16310#discussion_r1591092950
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3132,7 +3153,7 @@ private void checkTaskDuration() throws
ExecutionException, InterruptedException
} else {
DateTime earliestTaskStart = computeEarliestTaskStartTime(group);
- if
(earliestTaskStart.plus(ioConfig.getTaskDuration()).isBeforeNow()) {
+ if
(earliestTaskStart.plus(ioConfig.getTaskDuration()).isBeforeNow() ||
group.getShutdownEarly()) {
Review Comment:
Changing stopTaskCount requires a Supervisor change, which defeats the whole
purpose ;)
My clusters generally run with stopTaskCount=1 which works very well ... but
for high taskCount jobs it is much more likely that one task will be cycling at
any given time, which would render this command useless ...
Furthermore I may have to cycle more than one task, depending on how many of
the tasks are running on the node being cycled ... that makes it that much more
likely that I will go above the stopTaskCount level.
... unless this command queues up the tasks for cycling, but I didn't think
that logic is in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
