georgew5656 commented on code in PR #16310:
URL: https://github.com/apache/druid/pull/16310#discussion_r1591247702
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3132,7 +3153,7 @@ private void checkTaskDuration() throws
ExecutionException, InterruptedException
} else {
DateTime earliestTaskStart = computeEarliestTaskStartTime(group);
- if
(earliestTaskStart.plus(ioConfig.getTaskDuration()).isBeforeNow()) {
+ if
(earliestTaskStart.plus(ioConfig.getTaskDuration()).isBeforeNow() ||
group.getShutdownEarly()) {
Review Comment:
in this implementation it would respect the stopTaskCount and not stop the
task until a "stop slot" is available.
I guess a alternate implementation could be to just short-circuit
stopTaskCount and always stop tasks that have been stopped early, let me think
about that a bit
i feel like having a config is too complicated imo, it should be one
behavior or the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
