suneet-s commented on code in PR #16310:
URL: https://github.com/apache/druid/pull/16310#discussion_r1595721192
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResource.java:
##########
@@ -395,6 +395,25 @@ public Response shutdown(@PathParam("id") final String id)
return terminate(id);
}
+ @POST
+ @Path("/{id}/{taskGroupId}/stopEarly")
Review Comment:
```suggestion
@Path("/{id}/taskGroups/restart")
```
I think we should add the keyword `taskGroups` to the API path to indicate
this is operating on the taskGroups of the supervisor. Also, it would be nice
if the API accepted a list of taskGroups instead of a single taskGroup so that
users can call it with many taskGroups. Something like
```
PUT .../supervisor/{id}/taskGroups/restart
{ "taskGroupIds": [...]}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
