kfaraz commented on code in PR #16393:
URL: https://github.com/apache/druid/pull/16393#discussion_r1591747011
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -1271,6 +1278,138 @@ public void remove(final Task task)
}
}
+ /**
+ * Acquire a read lock to perform the segment transactional append action
for a given datasource.
+ * Also verifies that all the locks are of the type APPEND for the task.
+ * @param task task to perform the append action
+ */
+ public void acquireTransactionalAppendLock(Task task)
+ {
+ acquireTransactionalAppendLock(task, LOCK_ACQUIRE_TIMEOUT_MILLIS);
+ }
+
+ @VisibleForTesting
+ void acquireTransactionalAppendLock(Task task, long lockAcquireTimeoutMillis)
Review Comment:
Why does this need to be exposed? You can have a test that waits for 10s.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -1271,6 +1278,138 @@ public void remove(final Task task)
}
}
+ /**
+ * Acquire a read lock to perform the segment transactional append action
for a given datasource.
+ * Also verifies that all the locks are of the type APPEND for the task.
+ * @param task task to perform the append action
+ */
+ public void acquireTransactionalAppendLock(Task task)
+ {
+ acquireTransactionalAppendLock(task, LOCK_ACQUIRE_TIMEOUT_MILLIS);
+ }
+
+ @VisibleForTesting
+ void acquireTransactionalAppendLock(Task task, long lockAcquireTimeoutMillis)
Review Comment:
Why does this need to be exposed? You can have a test that waits for 10s or
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
