kfaraz commented on code in PR #16393:
URL: https://github.com/apache/druid/pull/16393#discussion_r1591755152
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -86,6 +88,11 @@
*/
public class TaskLockbox
{
+ private static final long LOCK_ACQUIRE_TIMEOUT_MILLIS = 10_000L;
+
+ private final Map<String, ReadWriteLock> datasourceToConcurrentLock = new
HashMap<>();
Review Comment:
Even if locks don't take very long to be acquired, it is still not advisable
to have a single lock per datasource. We need to include interval into the
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
