AmatyaAvadhanula commented on code in PR #16393:
URL: https://github.com/apache/druid/pull/16393#discussion_r1591784740
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -86,6 +88,11 @@
*/
public class TaskLockbox
{
+ private static final long LOCK_ACQUIRE_TIMEOUT_MILLIS = 10_000L;
+
+ private final Map<String, ReadWriteLock> datasourceToConcurrentLock = new
HashMap<>();
Review Comment:
One approach could be to maintain intervals currently held and waiting to be
locked and implement a logic similar to shared and exclusive locks that already
exists in TaskLockbox. When at transactional replace is released, any
transactional append waiting on it can be signalled. However, it is always
possible that one append is waiting on multiple replaces and vice versa.
I think that including the intervals into the logic makes it more involved
and risky.
Could you please share any alternative suggestions to implement this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
