LakshSingla commented on PR #16322: URL: https://github.com/apache/druid/pull/16322#issuecomment-2104696793
Thanks for a thorough review @gianm 😄 I have updated the PR since the last review with all of the review comments. Here's a summary of the changes: 1. Regarding the `CalciteNestedDataQueryTest` failures - I have addressed all of those. Few tests are still incompatible due to MSQ's limitation of not having field writers for nested arrays, and a few are incompatible because the nested virtual column isn't able to provide the correct type inference for sparse or non existent types. 2. Added the benchmarks and tested out that there's no regression in the code before and after this patch. I am rerunning the benchmarks with the nested data stuff. This will also add as a sanity check the code after the latest round of changes. 3. Modified the methods to not wrap the byte array into a Memory 4. Modified the readers to cache the column type and metric serde in an array 5. Have added the tests mentioned in the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
