LakshSingla commented on code in PR #16322: URL: https://github.com/apache/druid/pull/16322#discussion_r1597137777
########## processing/src/main/java/org/apache/druid/frame/key/ByteRowKeyComparator.java: ########## @@ -44,23 +45,30 @@ public class ByteRowKeyComparator implements Comparator<byte[]> private final int firstFieldPosition; private final RowKeyComparisonRunLengths rowKeyComparisonRunLengths; private final RowSignature rowSignature; + private final ComplexMetricSerde[] complexMetricSerdes; Review Comment: Regarding 2, the array is not null if there are no serdes, it's filled with nulls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
