georgew5656 commented on code in PR #16510:
URL: https://github.com/apache/druid/pull/16510#discussion_r1624783214
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/PodTemplateTaskAdapter.java:
##########
@@ -126,7 +132,19 @@ public PodTemplateTaskAdapter(
@Override
public Job fromTask(Task task) throws IOException
{
- PodTemplate podTemplate = templates.getOrDefault(task.getType(),
templates.get("base"));
+ ExecutionBehaviorStrategy behaviorStrategy;
+ ExecutionConfig executionConfig = executionConfigRef.get();
+ if (executionConfig == null || executionConfig.getBehaviorStrategy() ==
null) {
+ behaviorStrategy = ExecutionConfig.DEFAULT_STRATEGY;
+ } else {
+ behaviorStrategy = executionConfig.getBehaviorStrategy();
+ }
+ String category = behaviorStrategy.getTaskCategory(task);
+ PodTemplate podTemplate = templates.getOrDefault(
+ category != null ? category : task.getType(),
Review Comment:
but if you leave this in then users will start to rely on this behavior, i
think it would be better to remove it before anyone has tried using the
DynamicTaskExecutionBehaviorStrategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
